Prevent update when nothing change on Entities with class inheritance #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Previously we used a mixture of the Identity Map class name, which could reference the root class as well as the actual class and result of get_class(). Changed to only use the existing $realClass variable.
|
Seems like this change is already part of: https://github.com/DoctrineEncryptBundle/DoctrineEncryptBundle Please see these comments:
The new package that I hope will be maintained by more than 1 person |
Zombaya
pushed a commit
to integr8rs/DoctrineEncryptBundle
that referenced
this pull request
Dec 15, 2024
Update CI dependencies for GHA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #25, #28 & #35.
The implementation didn't handle Entities using class inheritance correctly as the Unit Of Work Identity Map entity name will refer to the root class of an Entity which uses inheritance but the cached decryptions array did not use the same reference.
This change adds tests for the scenario and provides a fix.
It also re-enables tests that were accidentally disabled by renaming the functional test cases from
*Test.phpto*TestCase.phpin #36 which meant they were not picked up by the filter in phpunit.xml.dist.