Fix/java codegen versioned namespace#204
Open
ospreyboi wants to merge 2 commits intoaccordproject:mainfrom
Open
Fix/java codegen versioned namespace#204ospreyboi wants to merge 2 commits intoaccordproject:mainfrom
ospreyboi wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: ospreyboi <akshaosprey460@gmail.com>
Signed-off-by: ospreyboi <akshaosprey460@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159
Hello!!
I was exploring the Accord Project codebase
and stumbled across this bug. I tried generating Java code
from a versioned Concerto model and noticed the version was just
silently dropped from the package name
which makes the output
incorrect and breaks downstream consumers.
Turns out
parseNamespace()already returns the version, it justwas not being used! The fixing was surprisingly small — just two lines
changed to destructure
versionalongsidenameand include itin the namespace string when present.
I also added a dedicated test case for versioned namespaces and
updated the snapshots so everything is consistent.
lib/codegen/fromcto/java/javavisitor.js— fixedstartClassFileand import generation to include version in namespace when present
test/codegen/fromcto/java/javavisitor.js— added test for versioned namespace