[DQT] Fix: DQT Beta Data Inconsistency#10348
Open
arnav-makkar wants to merge 6 commits intoaces:mainfrom
Open
Conversation
Collaborator
|
See comment on linked issue |
Contributor
Author
|
I've updated the logic to use a frontend toggle instead of backend filtering, as suggested by @ridz1208.
Testing:
Demo Videos: Screen.Recording.2026-02-08.at.16.37.07.movScreen.Recording.2026-02-08.at.16.39.52.movThe failing test is unrelated to changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
The beta Data Query Tool was displaying candidates with no instrument data, while the old DQT correctly filtered them out.
Root Cause
When queries included both candidate metadata fields (PSCID, CandID) and instrument fields (BMI data), candidates with only metadata but no instrument data were appearing as empty rows.
Solution
Added filtering logic in
QueryDataProvisioner._mergeIterators()to skip candidates where all non-metadata fields are empty. This mimics the old DQT's CouchDB behavior.The filter excludes candidate metadata fields (PSCID, CandID, DoB, Sex) when checking for data presence, ensuring only candidates with actual instrument data are included in results.
Testing
Before:
data-2026-02-07T18_59_19.122Z.csv
After:
data-2026-02-07T18_57_54.273Z.csv
Link(s) to related issue(s)