fix(env): Various env-related robustness fixes/improvements#3419
Conversation
pxrl
requested review from
bmzig,
dijanin-brat,
mrice32 and
nicholaspai
as code owners
pxrl
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 631074a801
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!binanceCredentialsConfigured()) { | ||
| return; |
There was a problem hiding this comment.
When BINANCE_API_KEY/secret are absent, this returns after super.initialize() has already stored all Binance routes and marked the adapter initialized. buildRebalanceRoutes() still emits Binance routes independently of hasBinanceRoute(), and CumulativeBalanceRebalancerClient evaluates candidate route costs by calling this.adapters[route.adapter].getEstimatedCost(...); any Binance candidate then reaches the binanceApiClient getter with _binanceApiClient unset and aborts the rebalance cycle. In no-Binance-credential environments with configured USDC/USDT/WETH cumulative targets, clear/filter availableRoutes (or avoid initializing the adapter/routes) instead of returning with supported routes but no client.
Useful? React with 👍 / 👎.
1 participant
No description provided.