Cgahr/master

[afonsoguerra]

No description provided.

[afonsoguerra]

Hey, I don't seem to have permissions to add to the other pull request or simply do not know how to do it . Let me know if this works better.

[cgahr]

Thank you for your bug fix!

The way you try to combine your bugfix with my rewrite is somewhat unorthodox. Typically, there are 2 ways of doing that:

1. the maintainer of this repo merge Complete rewrite to python 3 and general cleanup #35 first. Next, you create a new PR applying your changes on top
2. you create a PR in my fork under https://github.com/cgahr/journal2ebook/, we iterate on it and everything gets merged together.

Option 1 is the way it is normally done, option 2 is (potentially) better since the profile bug is fixed before the PR is merged onto master.

Your option, pushing your changes onto mine, is frowned up, since essentially you become the author of all the changes I did. This it is also not possible to track in git that I made these changes, which is helpful for future bug fixes.

Finally, I just updated my PR. Now this PR is out of date and doesn't reflect the actual status anymore.

I hope this was helpful! In my PR, I added a section in the readme about getting started developing and fixing bugs. Maybe you can read it, install the tooling and checkout the feedback of the linters. Also, if you want, you can create a PR in my repo https://github.com/cgahr/journal2ebook/ and merge your fix before merging the rewrite.

[afonsoguerra]

Are you sure this overwrites your authorship? You are still tagged here as the author of most of the commits. My priority here was just to make the code available to you nice people today. Very happy to do a PR in your repo and you can merge it there and take it forward. Realistically, I don't have time for 'pet projects' during the week, so it will be nice to ping it back to you to wrap up the release.

[adasilva]

Suggest using the python logging library instead of print statements. This is best practice because it allows the end user to have more control of the logging level.

[adasilva]

Are you sure this overwrites your authorship? You are still tagged here as the author of most of the commits. My priority here was just to make the code available to you nice people today. Very happy to do a PR in your repo and you can merge it there and take it forward. Realistically, I don't have time for 'pet projects' during the week, so it will be nice to ping it back to you to wrap up the release.

First of all, thanks for the bug fix! I just merged @cgahr 's pull request, so if you would be able to fix any conflicts, I can take a look. I also have a "day job" so I totally understand if it takes a few weeks. (Anyone who need the fix today can always pull your branch!)