Skip to content

Update Entry.php#93

Open
draev wants to merge 1 commit into
adldap:masterfrom
draev:patch-1
Open

Update Entry.php#93
draev wants to merge 1 commit into
adldap:masterfrom
draev:patch-1

Conversation

@draev

@draev draev commented Aug 25, 2015

Copy link
Copy Markdown

The last array index with X elements will be X-1

@draev

draev commented Sep 1, 2015

Copy link
Copy Markdown
Author

any comments about this fix ?

it really meaningful to fix it asap, when you handle php warnings as exceptions...

@rnowosielski

Copy link
Copy Markdown

Are you planning to merge this ? I was trying to use the lib but this bug makes it impossible to use for my purpose.

@rootpd

rootpd commented Sep 19, 2015

Copy link
Copy Markdown

+1 for merging. there really was a bug, this oneliner fixes it.

@juvinious

Copy link
Copy Markdown

^ Fourthed, please merge. Thanks.

@igorrynkovoy

Copy link
Copy Markdown

Please merge 👍

@aka-toxa

Copy link
Copy Markdown

lgtm 👍

@melya

melya commented Sep 22, 2015

Copy link
Copy Markdown

+1

1 similar comment
@andriictkn

Copy link
Copy Markdown

👍

@arodik

arodik commented Sep 22, 2015

Copy link
Copy Markdown

great 👍

@strebl

strebl commented Sep 22, 2015

Copy link
Copy Markdown

Don't expect any help here... Switch to Adldap2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.