-
Notifications
You must be signed in to change notification settings - Fork 14
Added $filters to AAS QL & enhanced Fragment Fieldidentifiers #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: IDTA-01002-3-2_working
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -625,10 +625,14 @@ components: | |
| type: string | ||
| pattern: "^-?(([1-9][0-9][0-9][0-9]+)|(0[0-9][0-9][0-9]))-((0[1-9])|(1[0-2]))-((0[1-9])|([12][0-9])|(3[01]))T(((([01][0-9])|(2[0-3])):[0-5][0-9]:([0-5][0-9])(\\.[0-9]+)?)|24:00:00(\\.0+)?)(Z|\\+00:00|-00:00)$" | ||
| type: object | ||
| modelStringPattern: | ||
| FieldIdentifier: | ||
| type: string | ||
| pattern: >- | ||
| ^(?:\$aas#(?:idShort|id|assetInformation\.assetKind|assetInformation\.assetType|assetInformation\.globalAssetId|assetInformation\.specificAssetIds\[[0-9]*\]\.(?:name|value|externalSubjectId(?:\.(?:type|keys\[[0-9]*\]\.(?:type|value)))?)|submodels\[[0-9]*\]\.(?:type|keys\[[0-9]*\]\.(?:type|value)))|\$sm#(?:semanticId(?:\.(?:type|keys\[[0-9]*\]\.(?:type|value)))?|idShort|id)|\$sme(?:\.[A-Za-z](?:[A-Za-z0-9_-]*[A-Za-z0-9_])?(?:\[[0-9]*\])*(?:\.[A-Za-z](?:[A-Za-z0-9_-]*[A-Za-z0-9_])?(?:\[[0-9]*\])*)*)?#(?:semanticId(?:\.(?:type|keys\[[0-9]*\]\.(?:type|value)))?|idShort|value|valueType|language)|\$cd#(?:idShort|id)|\$aasdesc#(?:idShort|id|assetKind|assetType|globalAssetId|specificAssetIds\[[0-9]*\]\.(?:name|value|externalSubjectId(?:\.(?:type|keys\[[0-9]*\]\.(?:type|value)))?)|endpoints\[[0-9]*\]\.(?:interface|protocolinformation\.href)|submodelDescriptors\[[0-9]*\]\.(?:semanticId(?:\.(?:type|keys\[[0-9]*\]\.(?:type|value)))?|idShort|id|endpoints\[[0-9]*\]\.(?:interface|protocolinformation\.href)))|\$smdesc#(?:semanticId(?:\.(?:type|keys\[[0-9]*\]\.(?:type|value)))?|idShort|id|endpoints\[[0-9]*\]\.(?:interface|protocolinformation\.href)))$ | ||
| FragmentFieldIdentifier: | ||
| type: string | ||
| pattern: >- | ||
| ^(?:\$aas#(?:idShort|assetInformation\.assetType|assetInformation\.globalAssetId|assetInformation\.specificAssetIds\[[0-9]*\](?:\.externalSubjectId(?:\.keys\[[0-9]*\])?)?|submodels\[[0-9]*\](?:\.keys\[[0-9]*\])?)|\$sm#(?:semanticId(?:\.keys\[[0-9]*\])?|idShort|id)|\$sme(?:\.[A-Za-z](?:[A-Za-z0-9_-]*[A-Za-z0-9_])?(?:\[[0-9]*\])*(?:\.[A-Za-z](?:[A-Za-z0-9_-]*[A-Za-z0-9_])?(?:\[[0-9]*\])*)*)?(?:#(?:semanticId(?:\.keys\[[0-9]*\])?|idShort|value|valueType|language))?|\$cd#idShort|\$aasdesc#(?:idShort|description|displayName|extension|administration|assetKind|assetType|globalAssetId|specificAssetIds\[[0-9]*\](?:\.externalSubjectId(?:\.keys\[[0-9]*\])?)?|endpoints\[[0-9]*\]|submodelDescriptors\[[0-9]*\](?:\.(?:semanticId(?:\.keys\[[0-9]*\])?|idShort|endpoints\[[0-9]*\]))?)|\$smdesc#(?:semanticId(?:\.keys\[[0-9]*\])?|idShort|endpoints\[[0-9]*\]))$ | ||
| MultiLanguagePropertyMetadata: | ||
| allOf: | ||
| - $ref: "#/components/schemas/SubmodelElementAttributes" | ||
|
|
@@ -792,7 +796,22 @@ components: | |
| pattern: ^id$ | ||
| $condition: | ||
| $ref: '#/components/schemas/logicalExpression' | ||
| $filters: | ||
| type: array | ||
| items: | ||
| $ref: '#/components/schemas/QueryFilter' | ||
| required: | ||
| - $condition | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Highlighting the naming inconsistency as explained in the above comment. |
||
| additionalProperties: false | ||
| QueryFilter: | ||
| type: object | ||
| properties: | ||
| $fragment: | ||
| $ref: '#/components/schemas/FragmentFieldIdentifier' | ||
| $condition: | ||
| $ref: '#/components/schemas/logicalExpression' | ||
| required: | ||
| - $fragment | ||
| - $condition | ||
| additionalProperties: false | ||
| QueryResultAssetAdministrationShell: | ||
|
|
@@ -1054,7 +1073,7 @@ components: | |
| type: object | ||
| properties: | ||
| $field: | ||
| $ref: '#/components/schemas/modelStringPattern' | ||
| $ref: '#/components/schemas/FieldIdentifier' | ||
| $strVal: | ||
| $ref: '#/components/schemas/standardString' | ||
| $strCast: | ||
|
|
@@ -1178,7 +1197,7 @@ components: | |
| type: object | ||
| properties: | ||
| $field: | ||
| $ref: '#/components/schemas/modelStringPattern' | ||
| $ref: '#/components/schemas/FieldIdentifier' | ||
| $strVal: | ||
| $ref: '#/components/schemas/standardString' | ||
| $numVal: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,7 +86,7 @@ enum SelectField { | |
| } | ||
|
|
||
| enum FieldIdentifier { | ||
| $strModel | ||
| $field | ||
| } | ||
|
|
||
| enum Value { | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please update all JSON examples that use
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would rather use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, I don't have any preferences, please use whatever makes sense and aligns with the AAS QL. This remarks is only to make sure whichever we decide, we use it everywhere and not a mix.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think in Security in ACL it is FORMULA (and CONDITION) whereas in the query language only "condition" is used, there is no $formula, only a $condition in Part 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighting the naming inconsistency as explained in the above comment.