fix: bump archiver ^6 -> ^7 to drop deprecated inflight (APPBLD-4614) - #234
Open
AnujVishwakarma-src wants to merge 1 commit into
Open
fix: bump archiver ^6 -> ^7 to drop deprecated inflight (APPBLD-4614)#234AnujVishwakarma-src wants to merge 1 commit into
AnujVishwakarma-src wants to merge 1 commit into
Conversation
archiver@6 pulls archiver-utils@4 -> glob@8 -> inflight@1.0.6 (deprecated). archiver@7 (archiver-utils@5) drops the inflight dependency entirely. Verified: 462 unit tests + lint pass; real-archiver zip smoke test passes; downstream aio-cli-plugin-runtime (1002 tests) passes with this build linked. archiver@7 keeps CommonJS support (archiver@8 is ESM-only). The remaining deprecated glob is closed separately via a scoped archiver-utils.glob override at the aio-cli install root (npm overrides are root-only). e2e requires OpenWhisk credentials and was not run locally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes APPBLD-4614 — clean up
npm warn deprecatedfrom@adobe/aio-lib-runtime.Bumps
archiver^6.0.1 → ^7.0.1.archiver@6pullsarchiver-utils@4 → glob@8 → inflight@1.0.6(deprecated).archiver@7(viaarchiver-utils@5) drops theinflightdependency entirely.archiver's public API used bysrc/utils.js(archiver('zip', { zlib }),.directory,.file,.finalize) is unchanged between v6 and v7; v7's only breaking change is dropping Node < 18 (this package requires>=20).Why not
archiver@8?archiver@8is ESM-only ("type": "module",import { ZipArchive } from "archiver"). Adopting it in this CommonJS package would force a full ESM migration (out of scope here).archiver@7is the CJS-safe ceiling.Note on the remaining
globarchiver@7still resolves a deprecatedglob@10transitively (archiver-utils@5pinsglob@^10; only glob 12/13 are non-deprecated). That is closed separately by a scopedoverrides: { "archiver-utils": { "glob": "^13" } }at theaio-cliinstall root — npmoverridesare only honored from the root project, so it cannot live in this library. Tracked as a follow-up.Before / after (real npm install warnings, this package as a dependency)
Before (
@adobe/aio-lib-runtime@7.4.0):After (this branch):
→
inflighteliminated from the archiver path.Validation
npm test— 462 unit tests pass, lint cleanarchiver@7zip smoke test (directory + file entries) produces a valid archive@adobe/aio-cli-plugin-runtime— 1002 tests pass with this build linked in (no regressions)RuntimeAPI_API_KEY,RuntimeAPI_NAMESPACE) and was not run locally