-
Notifications
You must be signed in to change notification settings - Fork 51
Copy on activation mode #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@snaeil do you mind checking this one? At least testing that it works on your machine. |
|
@maxbol I checked it on Linux and it seems to work in general :-) , but textfox = {
enable = true;
profile = "convenient";
copyOnActivation = true;
config = {
background = {
color = "#191724";
};
border = {
color = "#908caa";
width = "1px";
transition = "1.0s ease";
radius = "1px";
};
newtabLogo = ''
Hello world!
What's going on?
'';
font = {
size = "12px";
accent = "#c4a7e7";
};
};
};because So quotes are missing for the logo string and line breaks are not done correctly. |
| done | ||
| cp -L ${configCss} "$HOME/$PROFILE_DIR/chrome/config.css" | ||
| chmod 744 "$HOME/$PROFILE_DIR/chrome/config.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxbol Why exactly permission 744? What is the executable permission needed for?
|
@maxbol Apart from my comments above, some merge conflicts would be to resolved. |
|
Oh dear. I was just about to have another look at this, and it looks like we've diverged quite a bit. I'll try to find some time to sort it out, but I'm going to have to have a look at your new integration with the firefox home-manager module and see if that works with all I've got going on on my end. End of the day I have a pretty specific setup (hot reloading of styles through a global theme manager), so it might be easier long term if I maintain my own nix module for this. |
Solves:
On MacOS, symlinking the chrome/ folder or any of it's contents produce inconsistent results, especially for userContent.css.
With this change, the
copyOnActivationoption can be set to true (and is by default on darwin hosts), which instead of symlinking the textfox configuration into place copies it into place on home manager activation.