Fixes some memory leaks in CGO usage #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently cgo does not seem to be able to link against the liblua.a that is provided by the standard Lua installation. You will need to build a liblua.so and install that in your system in order for this binding to work. Hopefully I can remove this limitation and create a standalone static golua, but I'm unsure how to do that at this time.
If you prefer to customize your lua source before installing the bindings, you can simply add your customisations to the lua-5.1.4 directory or alter the CGO_OFILES and CGO_CFLAGS accordingly.
…e at the package level. Rename the package from lua51 to golua and move the source into the base directory.
… to fix linking on linux.
…t from afitz's repo. Also, minor tweak to Makefile so it will build in the proper order.
- use dynamic library instead. - use system /usr/include/lua5.1 (probably should use pkg-config or similar) - remove comment in readme did not want -- the version on my system is the version I want to bind against, and I see no compelling reason to keep a whole tree inline. To include alternate headers/dylib, modify the makefile defaults. For that matter, you'll probably need to tweak them for anything that's not my exact version of debian sid, but this is my branch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still seeing something leaking in my code, but my memory usage seems to be much more stable with these applied (esp when doing repeated calls into lua with go values)