-
Notifications
You must be signed in to change notification settings - Fork 300
Feat/asyncapi add reply #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/asyncapi add reply #2635
Conversation
|
@Lancetnik Hi! I also have a question: after my changes, a lot of tests started failing because they assert the exact payload output, like this: assert len(payload) == 1
key, value = next(iter(payload.items()))
assert key == "User"
assert value == {
"properties": IsDict({
"id": {"title": "Id", "type": "integer"},
"email": {"default": "", "title": "Email", "type": "string"},
})
| IsDict({
"id": {"title": "Id", "type": "integer"},
"name": {"default": "", "title": "Name", "type": "string"},
}),
"required": ["id"],
"title": key,
"type": "object",
}The failures are caused by the fact that I added a new payload to the output. Do you think it makes sense to update all these tests, or is there a better way to handle this? |
|
@stefan-vasilenko thank you! At first look everything looks fine. Let me check in details, what we can make with failing tests |
Description
Added reply generation to AsyncApi scheme v3.0.0
Fixes #1586
Type of change
Please delete options that are not relevant.
Checklist
just lintshows no errors)just test-coveragejust static-analysis