Repository navigation
fix: honor skipChecks in Vitest helpers - #139
Merged
Merged
Conversation
Forward top-level skipChecks to the runner in both helpers and add regression coverage for inline and loaded configurations. Use neutral explicit-skip wording and update CI guidance to prefer exclusion lists. Fixes #133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #133.
Both Vitest helpers resolved
skipChecksfrom configuration but omitted it when building the options forrunChecks. The runner already supported explicit exclusions; the helpers now forwardconfig.skipChecksasskipCheckIds.Check explicitly skipped, independent of the entry point, and update runner/dependency assertions.skipChecksin CI guidance so newly added checks remain enabled; remove the obsolete helper limitation.Verification
skipCheckIdsis absent, and pass afterward.npm run version:check,npm run lint,npm run format:check, andnpm run buildpass.No check implementations or scoring rules changed.