Repository navigation
ate-setup accepts bootstrap owners that contain a comma - #2748
Open
Eric Curtin (ericcurtin) wants to merge 3 commits into
Open
Eric Curtin (ericcurtin) wants to merge 3 commits into
Eric Curtin (ericcurtin) wants to merge 3 commits into
Conversation
Contributor
Author
|
Haven Xia (@HavenXia) Zoe Zhao (@zoez7) PTAL when you get a chance. Thank you! |
Bowei Du (bowei)
added
area/dev-infra
area/security
Eric Curtin (ericcurtin)
force-pushed
the
principal-list-csv
branch
from
October 20, 2026 11:46
588bb90 to
6a2f190
Compare
Eric Curtin (ericcurtin)
force-pushed
the
principal-list-csv
branch
from
October 23, 2026 01:34
6a2f190 to
c8d7f61
Compare
Contributor
Author
|
Rebased onto main, c8d7f61, as asked. Haven Xia (@HavenXia) Bowei Du (@bowei) PTAL when you get a chance. Thank you! |
Member
|
LGTM. But according to https://groups.google.com/g/ate-dev/c/vFELtvQLJ5g you need special approval for such change to merge now. |
Contributor
Author
|
Tim Hockin (@thockin) Eitan Yarmush (@EItanya) PTAL when you get a chance. It has an LGTM and needs a slush approval. Thank you! |
Collaborator
|
Is this really important for GA or could it land in the next release - O(weeks) later? |
Contributor
Author
|
Not GA-critical. It only matters for a principal that contains a comma, which is rare. Fine to land after GA. |
Shruti Nair (SHRUTI6991)
self-requested a review
October 24, 2026 22:56
2 tasks done
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2729
ate-setupnow reads the bootstrap owners as CSV, likeate-api-server's flag, through one sharedprincipal.ParseListandprincipal.FormatList.