Repository navigation
ateapi: skip deleting external volumes when Terminate or volume detach fails - #3112
Open
Abhay Joshi (abhayjoshi201) wants to merge 1 commit into
Conversation
Bowei Du (bowei)
added
area/api-machinery
area/reliability
area/storage
kind/bug
41 tasks
Abhay Joshi (abhayjoshi201)
force-pushed
the
fix/delete-actor-skip-volumes-on-terminate-err
branch
from
November 11, 2026 08:37
c11fbc1 to
3cb8cdc
Compare
…h fails DeleteActor called ensureVolumesDeleted even when ensureAteletTerminated or ensureVolumesDetachedForDelete returned an error. When a CSI driver deletes a still-published volume and returns NotFound from NodeUnpublishVolume on the retried Terminate, atelet skips unmounting and resetActorDirs fails with EBUSY on the mounted volume directory. Skip ensureVolumesDeleted whenever ensureAteletTerminated or ensureVolumesDetachedForDelete fails, matching ensureWorkerReleased, so external volumes are deleted only after node termination and volume detachment succeed. Signed-off-by: Abhay Joshi <abhayjoshi@google.com>
Abhay Joshi (abhayjoshi201)
force-pushed
the
fix/delete-actor-skip-volumes-on-terminate-err
branch
from
November 11, 2026 11:12
3cb8cdc to
ccd6750
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteActorcalledensureVolumesDeletedeven whenensureAteletTerminatedorensureVolumesDetachedForDeletereturned an error. When a CSI driver deletes a still-published volume and returnsNotFoundfromNodeUnpublishVolumeon the retriedTerminate,ateletskips unmounting andresetActorDirsfails withEBUSYon the mounted volume directory.Skip
ensureVolumesDeletedwheneverensureAteletTerminatedorensureVolumesDetachedForDeletefails, matchingensureWorkerReleased, so external volumes are deleted only after node termination and volume detachment succeed.Fixes #2971
AI use: AI-assisted; I reviewed the diff and verified the unit and functional test suites locally.