Repository navigation
podcertcontroller: signers share one certificate lifetime check - #3603
Open
Eric Curtin (ericcurtin) wants to merge 2 commits into
Open
Eric Curtin (ericcurtin) wants to merge 2 commits into
Eric Curtin (ericcurtin) wants to merge 2 commits into
Conversation
podidentity and servicedns dereferenced MaxExpirationSeconds without a nil check, and neither enforced the one hour minimum that postgres did. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
Dmitry Berkovich (@dberkov) Lior Lieberman (@LiorLieberman) PTAL when you get a chance. Thank you! |
2 tasks done
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
podidentityandservicednssigners dereferencedMaxExpirationSecondswithout a nil check, and neither enforced the one hour minimumpostgresdid. All three now usepodcertificate.Lifetime.Fixes #3034
AI use: AI-assisted (opencode). I reviewed it. Unit tests, lint and boilerplate checks run locally.