Repository navigation
Use ExternalVolumeClasses instead of StorageClasses in demos, e2e tests and benchmarks - #3806
Draft
Vu Le (lekhoavu2909) wants to merge 22 commits into
Draft
Vu Le (lekhoavu2909) wants to merge 22 commits into
Vu Le (lekhoavu2909) wants to merge 22 commits into
Conversation
regenerate ateapi.go, and register ExternalVolumeClass in apitool TestBuild_Annotations. Signed-off-by: Vu Le <vulk@google.com>
controlapi.ServiceImpl store pass-throughs Signed-off-by: Vu Le <vulk@google.com>
table truncation and driver_name column test Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
apitool example Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Signed-off-by: Vu Le <vulk@google.com>
Vu Le (lekhoavu2909)
force-pushed
the
evc-pr8-cutover
branch
from
November 11, 2026 22:48
411836d to
9d5549e
Compare
Draft
1 of 2 tasks
41 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the repo's demos, e2e tests and benchmarks from the csi-nfs-sc and csi-hostpath-sc Kubernetes StorageClasses to the csi-nfs and csi-hostpath ExternalVolumeClasses, and stops CSI setup from creating the StorageClasses. Stacked on #3800. storage_class_name still works in the API; only the repo's own tooling changes.
Part of #3754
AI use: AI-assisted, I reviewed and tested it.
Breaking change: for repo tooling only, not the API. Renamed flags and settings:
ate-setup counter demo: --storage-class / STORAGE_CLASS / demo.counter.storageClass → --external-volume-class / EXTERNAL_VOLUME_CLASS / demo.counter.externalVolumeClass (default csi-nfs)
e2e: --storage-class → --external-volume-class (default csi-nfs)
benchmarks: --storage-class-name / STORAGE_CLASS_NAME → --external-volume-class / EXTERNAL_VOLUME_CLASS
External-volume demos, e2e cases and benchmarks now need the ExternalVolumes preview at setup time, because setup no longer creates a StorageClass to fall back on.
Tests pass
Docs updated