Repository navigation
Allow ListActors to hide temporary golden snapshot actors - #3813
Draft
Arunkumar Eli (arun-elr) wants to merge 1 commit into
Draft
Arunkumar Eli (arun-elr) wants to merge 1 commit into
Arunkumar Eli (arun-elr) wants to merge 1 commit into
Conversation
Mark actors created by the template reconciler and add an opt-in list filter. Preserve pagination cursors and keep unmarked actors visible, including actors created before the marker existed. Signed-off-by: Arunkumar Eli <elrarun@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3788.
Add
ListActorsRequest.exclude_golden_actors, defaulting to false. The template reconciler marks its new actors withstatus.golden_snapshot_actor; public CreateActor and UpdateActor cannot set or clear that marker. Filtering keeps the pagination cursor, including on empty pages.The API shape is proposed for discussion. Older unmarked golden actors remain visible; this avoids classifying user actors by their names and requires no database migration. Both runtimes use the same control-plane path.
New PostgreSQL-backed tests pass with
-race -count=3 -shuffle=on, covering scoped/global pagination, the default listing, ordinary UUID names, and attempts to forge or clear the marker. Disabling the implementation makes the regressions fail. The complete control API, functional, and API validation suites also pass with-race; code generation verification passes. A repository-wide race run hit a router port collision and terminal-color failures, both reproduced on unchanged main. The color tests pass withNO_COLORunset. All repository verifiers pass (the two lint checks were rerun with serialized execution after a shared-lock conflict). Deployed gVisor/microVM E2E has not been run.AI use: Codex assisted with implementation, tests, and independent review.