Skip to content

Conversation

@josevalim
Copy link
Contributor

No description provided.

@josevalim josevalim requested a review from a team November 10, 2025 16:03
@SteffenDE
Copy link

For context: we opened zed-industries/claude-code-acp#145 to explore how this could be implemented. The PR also suggested a session/resume functionality, but that would be a separate draft.

For Claude Code, the SDK already provides the blocks we'd need to implement this: forkSession and resume. I'm imagining the API could look like this:

{
  "jsonrpc": "2.0",
  "method": "session/fork",
  "params": {
    "sessionId": "EXISTING-ACP-SESS-ID"
  }
}

Optionally, we could require to also pass any other parameters from session/new, like cwd and mcpServers for the forked session, but that might be different depending on the agent.

The agent would then reply with the same format as session/new, creating a new ACP sessionId for the forked session.

Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Added some comments, I can also take a look to figure out what we'd need to do for Codex and others as well

@josevalim josevalim requested a review from a team as a code owner November 17, 2025 20:22
Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some small tweaks to inline some examples, and also tweaked the capability structure a bit since we have a few session capabilities now (and could also make a plan to migrate the load one)

But looks good to me!

@benbrandt benbrandt merged commit 6665c44 into agentclientprotocol:main Nov 20, 2025
1 check passed
@josevalim
Copy link
Contributor Author

Thank you!!! 🥳 🍾

@josevalim josevalim deleted the patch-3 branch November 20, 2025 12:57
@SteffenDE SteffenDE mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants