Skip to content

fix: parse TaskList output without ambiguous regex - #1006

Open
jsgrrchg wants to merge 2 commits into
agentclientprotocol:mainfrom
jsgrrchg:fix/tasklist-redos
Open

fix: parse TaskList output without ambiguous regex#1006
jsgrrchg wants to merge 2 commits into
agentclientprotocol:mainfrom
jsgrrchg:fix/tasklist-redos

Conversation

@jsgrrchg

@jsgrrchg jsgrrchg commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the ambiguous regex used to parse textual TaskList output with linear string parsing.
  • Preserve support for owners, multiple dependencies, and malformed suffixes treated as subject text.
  • Add a regression test covering adversarial input.

This addresses a potential ReDoS reported by CodeQL without changing the structured JSON path.

Closes #1005.

Testing

  • npm run test:run
  • npm run build
  • npm run check

@jsgrrchg
jsgrrchg marked this pull request as ready for review August 15, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential ReDoS in parseTaskListOutput textual fallback

1 participant