fix: publish task notifications as typed session failures - #1028
Open
nikita-ashihmin wants to merge 2 commits into
Open
fix: publish task notifications as typed session failures#1028nikita-ashihmin wants to merge 2 commits into
nikita-ashihmin wants to merge 2 commits into
Conversation
Claude Code persists internal task notifications as user messages, so session replay exposed failures as user-authored transcript entries. Publish trusted failed and stopped notifications through the negotiated AIR sessionFailure extension while retaining the legacy replay for clients without it. IJAI-1225
Completed task notifications are internal delivery envelopes rather than failures and may omit a summary. Recognize them without requiring failure text so replay cannot expose them as user-authored messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task_notificationevents as negotiated AIRsessionFailureupdatesorigin.kind = task-notificationenvelopes without exposing them asuser_message_chunkfailedto error andstoppedto warning, with stable identities and increasing revisionscompletedenvelopes without creating a failure rowsessionFailurecapabilityUser-authored XML is not trusted and remains a user message.
Tracks IJAI-1225.
Related work
#941 also reads trusted task-notification messages, but uses them to close background-agent tool lifecycle records. It does not publish typed failures or remove the user bubble. Both changes intentionally use the SDK-provided origin as the trust boundary; the overlapping parser may need consolidation if #941 lands first.
Verification
npm run checknpm run buildenv -u ANTHROPIC_BASE_URL npm run test:run— 971 passed, 27 skipped