fix: preserve native Vertex endpoint defaults - #1104
Open
kocaemre wants to merge 1 commit into
Open
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ANTHROPIC_VERTEX_BASE_URLunset whenproviders/setselects Vertex's native default endpointANTHROPIC_VERTEX_BASE_URLonly for custom Vertex gateways/endpointsCloses #1087
Test Plan
npm run test:run -- src/tests/providers.test.ts— passed (21 tests)npm run check— passed (eslint src --ext .ts+prettier --check .)npm run build— passed (tsc)git diff --check origin/main..HEAD— passedNote:
claude -pdelegation was attempted for candidate discovery but this cron shell's Claude Code auth is not logged in (Not logged in · Please run /login), so the implementation/validation above was done directly with local tests.