fix(steering): reject a missing post-echo result - #969
Open
ran411285752 wants to merge 2 commits into
Open
Conversation
Why: agentclientprotocol#958 could reject a prompt on the interrupted cycle's diagnostic result, then reuse that pre-echo result if the steered cycle ended without its own result. What: Treat pre-echo results as superseded outcomes, clear them when the matching steering echo arrives, and reject an idle steered cycle that has no post-echo result. Add focused regression coverage for both boundaries. Impact: Only active injected steering settlement changes; agentclientprotocol#958's steeredEchoes/steeredSettle state machine remains authoritative.
Contributor
Author
|
@Rizzen, could you please review this focused follow-up to #958 when you have a chance? It keeps #958's steering state machine and only fixes the pre-echo diagnostic-result rejection and the post-echo stale-result reuse described above. The branch is mergeable and the focused Steering/background-subagent tests pass locally. |
…sult-boundaries # Conflicts: # src/acp-agent.ts # src/tests/acp-agent.test.ts
ran411285752
changed the title
Contributor
Author
|
Merged current main at caf609b and resolved the overlap with #967: this PR now contains only the post-echo stale-result fix. Fresh RED reproduced the false end_turn success; the focused Steering/ExitPlanMode suite is green (6 tests), and build/lint pass. @Rizzen, could you please approve Actions and review the narrowed diff? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #958. After merging current
main(caf609b), #967 already covers the pre-echo diagnostic-result failure, so this PR is now limited to the remaining post-echo result-boundary bug:steeredSettlewhen the matching steering echo replays;no_resulterror instead of reusing the interrupted cycle's successful result.User impact
A steered instruction that starts but never produces its own final result is no longer reported as successfully completed using the result from before the instruction ran.
Tests
Fresh RED on current
mainbehavior:does not reuse the interrupted result after the steered echoincorrectly resolvedend_turnwith 15-token pre-echo usage.GREEN and adjacent verification:
npm run build: passed;npm run lint: passed;npx prettier --check src/acp-agent.ts src/tests/acp-agent.test.ts: passed;git diff --check: passed.Windows repo-wide baseline:
npm run test:run: 949 passed, 23 failed, 27 skipped. Failures are in untouched path/permission formatting tests and three 5-second timeouts; the focused Steering tests pass.