-
Notifications
You must be signed in to change notification settings - Fork 34
feat(evaluators): add new lluna client #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
namrataghadi-galileo
wants to merge
24
commits into
main
Choose a base branch
from
feature/64546-add-new-luna-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9f1791a
add new lluna client
namrataghadi-galileo 8d2227d
fix the url
namrataghadi-galileo db02db8
Merge branch 'main' into feature/64546-add-new-luna-client
namrataghadi-galileo 0cce0bf
feat(galileo): support internal scorer auth
namrataghadi-galileo dd252be
add auth and update schema
namrataghadi-galileo 74fcbeb
fix(galileo): align luna scorer response schema
namrataghadi-galileo 7b0a15d
update the schemas and corresponding tests
namrataghadi-galileo 523524d
update the schemas for scorer
namrataghadi-galileo 34f430d
update luna client schemas
namrataghadi-galileo ad0b2dc
fix tests
namrataghadi-galileo 81cea04
remove unwanted fields
namrataghadi-galileo f3cf8f7
remove project_id from evaluator config
namrataghadi-galileo 9cf463a
Merge branch 'main' into feature/64546-add-new-luna-client
namrataghadi-galileo 025f96f
add evaluator context
namrataghadi-galileo 15e7a01
remove evaluation context
namrataghadi-galileo a06d3f1
add tests for coverage
namrataghadi-galileo c8662f7
coverage
namrataghadi-galileo 9a94bba
move coervagera
namrataghadi-galileo f0d11b7
failing test
namrataghadi-galileo f683dda
add input text that goes into controls evaluators
namrataghadi-galileo 7210fc1
add docstring
namrataghadi-galileo 81a5f1d
Merge branch 'main' into feature/64546-add-new-luna-client
namrataghadi-galileo 2c1b488
Merge branch 'main' into feature/64546-add-new-luna-client
namrataghadi-galileo f513dac
address comments
namrataghadi-galileo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadata = dict(result.metadata or {})thenmetadata["selected_data"] = dataunconditionally overwrites whatever the evaluator deliberately put underselected_data. Evaluators do return that key (see the mock inengine/tests/test_core.py:160), and an evaluator might want to ship a sanitized or transformed version. The contract is not currently clear about who owns the key — consider namespacing the engine-injected value (e.g.engine_selected_data) so it cannot collide with evaluator-supplied metadata.