fix(harness): offload memory flush and compaction work#1618
fix(harness): offload memory flush and compaction work#1618guslegend0510 wants to merge 7 commits into
Conversation
|
Looks like this branch has some noise/unrelated commits. Could you please pull the latest from main and recreate your branch, or interactive rebase to remove the extra changes? |
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This is a massive refactoring PR (2366 files, +128450/-214619) that reverts ReActAgent state management from AgentState back to InMemoryMemory, removes the Middleware system in favor of Hooks, simplifies Toolkit.registerToolMethod, and un-deprecates a large number of classes previously marked for removal in 2.0.0. The PR title ("offload memory flush and compaction work") significantly understates the scope — the actual changes constitute a major architectural pivot. Key concerns: (1) mass removal of @Deprecated(forRemoval=true) annotations without migration guidance creates API stability confusion, (2) shared mutable state via toolkit.setInternalChunkCallback() in acting(), (3) non-atomic InMemoryMemory.loadFrom(), and (4) potential logic gap in summarizing() pending tool handling. Recommend addressing the critical API compatibility issue and the concurrency concerns before merge.
(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)
47206cf to
05f6b2f
Compare
05f6b2f to
2674584
Compare
…ize Windows tests
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@LearningGp 我已经完成了您前面说的变更,麻烦您看一下谢谢 |
Moves memory flush, JSONL offload, and compaction-adjacent workspace IO onto boundedElastic. Also fixes a core ToolCallParam builder regression and keeps agentscope-extensions POM aligned so harness tests compile.
Verified with:
mvn -s D:\Code??\agentscope-java\codex-settings.xml -pl agentscope-harness -am "-Dtest=MemoryFlushManagerTest,ConversationCompactorTest" test "-Dspotless.check.skip=true"