Skip to content

fix(harness): offload memory flush and compaction work#1618

Open
guslegend0510 wants to merge 7 commits into
agentscope-ai:mainfrom
guslegend0510:work/pr1612-harness-offload
Open

fix(harness): offload memory flush and compaction work#1618
guslegend0510 wants to merge 7 commits into
agentscope-ai:mainfrom
guslegend0510:work/pr1612-harness-offload

Conversation

@guslegend0510

Copy link
Copy Markdown

Moves memory flush, JSONL offload, and compaction-adjacent workspace IO onto boundedElastic. Also fixes a core ToolCallParam builder regression and keeps agentscope-extensions POM aligned so harness tests compile.

Verified with:

mvn -s D:\Code??\agentscope-java\codex-settings.xml -pl agentscope-harness -am "-Dtest=MemoryFlushManagerTest,ConversationCompactorTest" test "-Dspotless.check.skip=true"

@guslegend0510 guslegend0510 requested a review from a team June 4, 2026 23:57
@AgentScopeJavaBot AgentScopeJavaBot added bug Something isn't working area/core Core library: agentscope-core (general) area/harness agentscope-harness (test/runtime support) labels Jun 5, 2026
@LearningGp

Copy link
Copy Markdown
Member

Looks like this branch has some noise/unrelated commits. Could you please pull the latest from main and recreate your branch, or interactive rebase to remove the extra changes?

@AgentScopeJavaBot AgentScopeJavaBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

This is a massive refactoring PR (2366 files, +128450/-214619) that reverts ReActAgent state management from AgentState back to InMemoryMemory, removes the Middleware system in favor of Hooks, simplifies Toolkit.registerToolMethod, and un-deprecates a large number of classes previously marked for removal in 2.0.0. The PR title ("offload memory flush and compaction work") significantly understates the scope — the actual changes constitute a major architectural pivot. Key concerns: (1) mass removal of @Deprecated(forRemoval=true) annotations without migration guidance creates API stability confusion, (2) shared mutable state via toolkit.setInternalChunkCallback() in acting(), (3) non-atomic InMemoryMemory.loadFrom(), and (4) potential logic gap in summarizing() pending tool handling. Recommend addressing the critical API compatibility issue and the concurrency concerns before merge.

(inline comments could not be attached — line numbers fell outside PR hunks. See archived report.)

@guslegend0510 guslegend0510 force-pushed the work/pr1612-harness-offload branch from 47206cf to 05f6b2f Compare June 9, 2026 13:55
@guslegend0510 guslegend0510 force-pushed the work/pr1612-harness-offload branch from 05f6b2f to 2674584 Compare June 9, 2026 15:04
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

@guslegend0510

Copy link
Copy Markdown
Author

@LearningGp 我已经完成了您前面说的变更,麻烦您看一下谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Core library: agentscope-core (general) area/harness agentscope-harness (test/runtime support) bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants