修复 workspace/project 文件列表路径归一化#1724
Conversation
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR fixes workspace/project file list path normalization by introducing Project.getStoragePath() to store the original storagePath value, and changing Workspace.getPath() return type from String to Path. It also fixes PathMatcher glob compatibility issues on Windows (FileSystemException → InvalidPathException) and adds Windows CI via GitHub Actions.
Recommendation: COMMENT — 2 critical issues + 1 recommended + 2 nitpicks
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR fixes workspace/project file list path normalization by introducing Project.getStoragePath() to store the original storagePath value, and changing Workspace.getPath() return type from String to Path. It also fixes PathMatcher glob compatibility issues on Windows (FileSystemException → InvalidPathException) and adds Windows CI via GitHub Actions.
Recommendation: COMMENT — 2 critical issues + 1 recommended + 2 nitpicks
AgentScopeJavaBot
left a comment
There was a problem hiding this comment.
🤖 AI Review
This PR fixes workspace/project file list path normalization by introducing Project.getStoragePath() to store the original storagePath value, and changing Workspace.getPath() return type from String to Path. It also fixes PathMatcher glob compatibility issues on Windows (FileSystemException → InvalidPathException) and adds Windows CI via GitHub Actions.
Recommendation: COMMENT — 2 critical issues + 1 recommended + 2 nitpicks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
背景
LocalFilesystemSpec.project()场景下,glob()返回的 project/lower 层绝对路径没有被统一转换为 workspace-relative,导致listKnowledgeFiles()/listMemoryFilePaths()在 project 目录存在时路径不一致。变更
验证
mvn -B "-Dspotless.check.skip=true" -pl agentscope-harness -am "-Dtest=WorkspaceManagerListingTest,BaseSandboxFilesystemTest,HarnessAgentTest" test