MNNVL Webhook Approach #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gflarity
requested review from
sanjaychatterjee and
unmarshall
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
GREP
What this PR does / why we need it:
Support automatica MNNVL Compute Domain management via annoations and webhooks.
Special notes for your reviewer:
Seems like focus are pretty set on encorporating ComputeDomain management into the Grove Operator itself. I'd like to understand why this approach isn't desirable, as it seems a lot simpler. I'd also like understand why this is considered less cloud-native, as my experience great webhooks managing resources automatically works very well and is quite common.