Allow for variable renaming in coupled modeling #1240
Open
Arcomano1234 wants to merge 2 commits into
Open
Conversation
…an atmospheric modeling during coupled training
Collaborator
|
I think this would be a reasonable feature to support. Although in my experience there are always a lot of tricky edge cases. Previously we had support for renaming variables within data loading, but we removed this due to the complexity of supported merged datasets: https://github.com/ai2cm/full-model/pull/1511. Keeping it confined to the coupled stepper for now at least limits surface area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we are attempting to mix and match an atmospheric model trained on ERA5 and an ocean model trained on UFS replay dataset. The problem is in ERA5 wind stresses are called
eastward_surface_stresswhile in CM4 and UFS replay they are calledeastward_surface_wind_stress. Given that we will not be using the atmospheric variables to train a new ACE version for the foreseeable future we need a way to allow variable renaming. Similar to how it was done for HiRO-ACE in the downscaling model, this PR adds an optional stepper argatmosphere_output_renamethat will remap the user specified atmospheric variables to be renamed when the ocean model is grabbing forcing variables. Can also be used during inference and standalone eval.Changes:
add
atmosphere_output_renameto coupled stepper that can rename atmospheric forcing variables for the ocean modelTests added