-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Add Source.fetch_record() andStream.fetch_record() backed by SimpleRetriever._fetch_one()
#846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronsteers
wants to merge
16
commits into
main
Choose a base branch
from
devin/1762976446-add-fetch-one-to-simple-retriever
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+372
−0
Open
feat: Add Source.fetch_record() andStream.fetch_record() backed by SimpleRetriever._fetch_one()
#846
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
38d13d3
feat: Add fetch_one/fetch_record functionality to SimpleRetriever
devin-ai-integration[bot] 052eb81
update type hints
aaronsteers c581827
Change fetch_one to raise RecordNotFoundException instead of returnin…
devin-ai-integration[bot] bab2781
Fix ruff format issues
devin-ai-integration[bot] a2e8e55
Improve path construction robustness in fetch_one
devin-ai-integration[bot] c0719e2
refactor: Move fetch_record to concurrent declarative classes only
devin-ai-integration[bot] 38f6dc3
fix: Address PR review comments
devin-ai-integration[bot] 0a71543
fix: Simplify error handling in fetch_one
devin-ai-integration[bot] 626848b
fix: Address PR review comments - add type hints and clarifying comments
devin-ai-integration[bot] bf83bf1
refactor: Use iterator instead of list for fetch_one record parsing
devin-ai-integration[bot] 691927b
refactor: Simplify fetch_one/fetch_record to only accept str for pk_v…
devin-ai-integration[bot] 8a52390
refactor: Rename fetch_one to _fetch_one to mark as internal API
devin-ai-integration[bot] 4386a35
fix: Address PR feedback from brianjlai on fetch_one implementation
devin-ai-integration[bot] 28b9286
Update unit_tests/sources/declarative/retrievers/test_simple_retrieve…
aaronsteers dfeeec2
Update unit_tests/sources/declarative/retrievers/test_simple_retrieve…
aaronsteers 82add1b
Update unit_tests/sources/declarative/retrievers/test_simple_retrieve…
aaronsteers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.