-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(source-tiktok-marketing): Send pixel_ids as JSON array for pixel_events_statistics stream #70241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(source-tiktok-marketing): Send pixel_ids as JSON array for pixel_events_statistics stream #70241
Conversation
…events_statistics stream Co-Authored-By: Vai Ignatavicius <[email protected]>
Original prompt from Vai |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
/bump-version
|
…hangelog entry Co-Authored-By: Vai Ignatavicius <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 6fc74ac. |
…l_ids parameter Co-Authored-By: Vai Ignatavicius <[email protected]>
|
What
Fixes a bug in the
pixel_events_statisticsstream wherepixel_idswas being sent as a string instead of a JSON array, causing the TikTok API to return error code 40002:pixel_ids: Field must be set to array.Reported in Slack by a customer who was unable to sync the
pixel_events_statisticsstream.How
Uses explicit JSON array syntax to ensure
pixel_idsis sent as a proper JSON array string in the query parameter.Before:
pixel_ids=7577353199770828808After:
pixel_ids=["7577353199770828808"](URL-encoded)The fix uses
"[\"{{ stream_partition['pixel_id'] }}\"]"to hard-code the JSON array brackets around the interpolated pixel ID value.Updates since last revision
| tojsonJinja filter did not work in testing (the parameter was still sent as a plain string). Switched to explicit JSON array syntax which should reliably produce the correct format.Review guide
airbyte-integrations/connectors/source-tiktok-marketing/manifest.yaml- Single line change using explicit JSON array syntaxairbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml- Version bump to 4.8.11-rc.3docs/integrations/sources/tiktok-marketing.md- Changelog entry (also fixed a malformed line from a previous merge)Human review checklist
"[\"{{ stream_partition['pixel_id'] }}\"]"produces the correct URL-encoded formatpixel_ids: Field must be set to arrayerror (previous| tojsonapproach failed in testing)User Impact
Users syncing the
pixel_events_statisticsstream will no longer encounter thepixel_ids: Field must be set to arrayerror.Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/a8d99d2e325f4e03b3354fa63f9a4308
Requested by: Vai Ignatavicius (@vai-airbyte)