Skip to content

security(CASA-11): remove API key from donke URL query parameters #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security(CASA-11): remove API key from donke URL query parameters #1025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/airweave/api/v1/endpoints/organizations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,9 +694,10 @@ async def _notify_donke_signup(
# Simple HTTP call to Donke (uses Azure app key)
async with httpx.AsyncClient() as client:
await client.post(
f"{settings.DONKE_URL}/api/notify-signup?code={settings.DONKE_API_KEY}",
f"{settings.DONKE_URL}/api/notify-signup",
headers={
"Content-Type": "application/json",
"x-functions-key": settings.DONKE_API_KEY,
},
json={
"organization_name": organization.name,
Expand Down
6 changes: 4 additions & 2 deletions backend/airweave/billing/webhook_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,9 +941,10 @@ async def _notify_donke_subscription(
try:
async with httpx.AsyncClient() as client:
await client.post(
f"{settings.DONKE_URL}/api/notify-subscription?code={settings.DONKE_API_KEY}",
f"{settings.DONKE_URL}/api/notify-subscription",
headers={
"Content-Type": "application/json",
"x-functions-key": settings.DONKE_API_KEY,
},
json={
"organization_name": org.name,
Expand Down Expand Up @@ -1012,9 +1013,10 @@ async def _send_team_welcome_email(
# Call Donke to send the welcome email
async with httpx.AsyncClient() as client:
await client.post(
f"{settings.DONKE_URL}/api/send-team-welcome-email?code={settings.DONKE_API_KEY}",
f"{settings.DONKE_URL}/api/send-team-welcome-email",
headers={
"Content-Type": "application/json",
"x-functions-key": settings.DONKE_API_KEY,
},
json={
"organization_name": org.name,
Expand Down
Loading