security(CASA-45): fix timing attack vulnerability #1026
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ?code= query parameter with x-functions-key header in all Donke API calls to comply with CASA-11 security requirements. Changes: - webhook_handler.py: Update notify-subscription and send-team-welcome-email calls - organizations.py: Update notify-signup call Azure Functions with AuthLevel.FUNCTION natively support both query param and header authentication. This change prevents API key exposure in server logs, browser history, and network monitoring tools. Fixes: ENG-165
…validation - Replace plain string comparison with secrets.compare_digest() in API key validation - Replace plain string comparison with secrets.compare_digest() in OAuth1 token validation - Prevents timing side-channel attacks that could leak credentials character-by-character Fixes CASA-45 compliance requirement for constant-time cryptographic operations. Addresses ENG-183.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
felixschmetz
approved these changes
Oct 29, 2025
Collaborator
felixschmetz
left a comment
felixschmetz
left a comment
There was a problem hiding this comment.
looks good, but needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes timing attack vulnerabilities in API key and OAuth1 token validation by replacing plain string comparisons with constant-time comparison functions.
Changes
crud_api_key.py): Usesecrets.compare_digest()instead of==for API key comparisoncrud_connection_init_session.py): Usesecrets.compare_digest()for OAuth token comparisonSecurity Impact
Testing
secrets.compare_digest()is functionally identical to==Closes #ENG-183
Summary by cubic
Hardens auth by using constant-time comparisons for API keys and OAuth1 tokens, and moves the Donke function key from URL query params to the x-functions-key header. Mitigates timing and credential leakage risks and meets CASA-45 and CASA-11.