Repository navigation
fix: gate on hunk-level recall, fixed before Stage 3a - #14
Merged
Merged
Conversation
A defective hunk counts as caught when it draws at least one finding under any rule. Run 2 showed the reviewer describing labelled defects under overlapping rules (R13 for an R4 label, R2/R13/R16 for R7), so rule recall measured naming as much as detection. Decided after runs 1-2 and changes neither outcome (1/15, 3/15 < 50%); committed now so Stage 3a is scored against it. Rule recall stays in the output, ungated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WkPsqEJ4QYWRW5eCFBYRPS
aisona-lab
marked this pull request as ready for review
October 23, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The fail-on gate now reads hunk recall instead of rule recall. Hunk recall is the share of in-scope defective hunks that draw at least one finding, under any rule. Rule recall is still printed, but it no longer gates anything.
Why
In run 2 (#13), the reviewer described two labelled defects correctly but under rules other than the label: R2/R13/R16 for an R7 label, and R7/R13 for an R4 label. The rules overlap, so rule recall partly measures which name the reviewer picked rather than whether it saw the defect.
Pre-registration
docs/hardening-plan.md.Known weakness: a finding about a different problem in the same hunk still counts (1 of 3 in run 2).
unlabelledis printed so a human can check.Proof
New tests:
Generated by Claude Code