Skip to content

moving line into the define case due to failure of puppet when line is outside #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

moving line into the define case due to failure of puppet when line is outside #246

wants to merge 65 commits into from

Conversation

@ppouliot
Copy link
Contributor

@ppouliot ppouliot commented Nov 8, 2018

Currently fails on newer versions of puppet. Moving this line inside of the defines allows for proper processing.

ppouliot and others added 30 commits November 8, 2018 16:22
@ppouliot
moving line into the define case due to failure of puppet when line i…
4cb6dfe 
…s outside
@primeministerp
trying to fix stdlib bits
e8c1e58
@primeministerp
updating to modern stdlib conventions
1e4568f
@primeministerp
updating
59b2a7b
@primeministerp
updating
e06b406
@primeministerp
fixing mismatched type
a5a46e6
@primeministerp
updating
5a5dd55
@primeministerp
Puppetfile
0820dc4
@primeministerp
fixing assert_types
414dc7c
@primeministerp
more cleanup and transition to modern Stdlib functions from depreciat…
f7805bc 
…ed ones
@primeministerp
more stdlib conversions for different record types
ba1b108
@primeministerp
more stdlib cleanup
fd3b5f5
@primeministerp
updating
ed1253c
@primeministerp
fixing wrong use of stdlib
379b0aa
@primeministerp
Proper working Stdlib integrations up to this point
6705c37
migrating to pdk for validation
fc6000c
@ppouliot
migrating to pdk for validation
09c2718
@ppouliot
Merge branch 'master' of github.com:ppouliot/puppet-dns
791545c
@ppouliot
lint cleanup for pdk validation
3447ed5
@primeministerp
minimal Puppetfile
96f8d11
@primeministerp
attempting to fix spec test
c72227f
@primeministerp
cleanup of unit tests
0eee214
@primeministerp
trying to fix spec tests
c9bd889
@ppouliot
Lint cleanup for readability
1cef8c0
@ppouliot
updating
4964889
@primeministerp
reverting params
e4178e6
@primeministerp
fixing param
92753ae
@primeministerp
fixing curly brackets that were not needed
233e13b
@ppouliot
Some rspec formatting changes
49acbd7
@ppouliot
reverting typo
0b404eb
ppouliot added 28 commits January 11, 2019 18:49
@ppouliot
more attempts to fix spec
106a0d3
@ppouliot
fixing bits
f9e0bd8
@ppouliot
updating spec tests and other realated bits
d26089a
@ppouliot
more spec and class cleanup to get pdk unit tests working
d8c3841
@ppouliot
reverting to validate_absolute_path until I can replace it
98ec81d
@ppouliot
more reverting to clear rspec errors until i can build clean
44c3c79
@ppouliot
Adding of Data types, to classes and other cleanup of spec testing
d527b11
@ppouliot
adding MIT license and anything missing
7c86c15
@ppouliot
updating readme
d0d8438
@ppouliot
fixing lint issues
4906e9d
@ppouliot
updating docummentation to support pdk changes
161b7cc
@ppouliot
pinning beaker-vagrant to 0.5.0
6638d78
@ppouliot
updating Jenkinsfile
717930d
@ppouliot
updating Jenkinsfile
085dcc4
@ppouliot
updating typo in spec_helper_acceptance.rb
66fee7b
@ppouliot
fixing spacing
f4ab7bc
@ppouliot
Updating pool
2b8d9f7
@ppouliot
fixing missing }
b82c94c
@ppouliot
Updating Jenkinsfile to add Gem Deps
f4494cf
@ppouliot
trying to fix errors
2dcd8ce
@ppouliot
more Jenkinsfile Updates
15a8f8c
@ppouliot
fixing typo in job
a09f843
@ppouliot
restrict jenkinsfile job to get basic testing working
edef461
@ppouliot
adding workspace cleaning to jenkinsfile
ed29de4
@ppouliot
adding .sync.yml to help with pdksync
6f9ea62
@ppouliot
adding missing gem versions requirements from Gemfile
06a828b
@ppouliot
catching missing bits
c56e63c
@ppouliot
Fixing jenkinsfile typo
ec588ed
@gremble gremble mentioned this pull request Feb 27, 2019
Open
@barnumbirr
Copy link

barnumbirr commented May 2, 2020

@ajjahn @jearls @solarkennedy Any update on getting this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ppouliot @barnumbirr @primeministerp