Clean Code (refractor move --> interfaces)#271
Clean Code (refractor move --> interfaces)#271thelittlefireman wants to merge 6 commits intoalamkanak:developfrom thelittlefireman:develop
Conversation
|
I'm not sure if I like this change because it will break all clients using our library (as they need to implement "other interfaces", they'll need to change their import statements) @alamkanak what do you think? |
|
@thelittlefireman also this PR isn't complete, i'm missing an interfaces folder |
|
sorry, it's fix now ;) |
|
Conflicts Fixes |
|
again |
|
@alamkanak Is this something we want to do? We'll break all current clients with this code. (We have 1534 stars on github so that might be a lot of clients that we're breaking). |
|
It's just the java convention code ... we cannot put all the code in only one Class, it's a mess ... |
|
We could have interfaces in the WeekView class that inherit from the real interfaces. + @deprecated tag. That way I can live with this change. Can you also update the documentation then? |
add deprecated tag and documentations
|
Done :) is that okay right now ? |
Cleaning code
By @thelittlefirman