This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Update to Wasmer 3.x - #6
Open
PieKing1215 wants to merge 6 commits into
Open
Conversation
Owner
|
This sounds great. I haven't thought about this code in a bit so I'm going to need some time to refresh before I feel comfortable merging but I'll try to take a closer look this weekend. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated this to wasmer 3.x while I was trying to debug a panic I was getting.
The only differences in the public API are:
call_functionandcall_function_with_argumentnow both take&mut self(call_function_with_argumentwas&selfbefore for some reason).import_function_with_contextandimport_functionboth require the function to beSyncnowOtherwise the changes are mainly just passing
Storereferences around more and updating some changed names.