Handle no changes for recipient #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszsamson
force-pushed
the
bugfix/handle_recipient_result-bug
branch
2 times, most recently
from
a33057a to
28179a4
Compare
lukaszsamson
force-pushed
the
bugfix/handle_recipient_result-bug
branch
from
28179a4 to
76c4ceb
Compare
Contributor
|
I rebased and cleaned up this PR. @alexgaribay can you review and marge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create new recipient it is possible that we actually update an existing one. In such case Sendgrid API doesn't send back the recipient_id inside
persisted_recipientsarray. We need to handle this because we can easily get this error:(MatchError) no match of right hand side value: []Also I added search from Sendgrid API