Skip to content

fix GSM-29: prevent duplicate theme deploys for the same PR #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheOrangePuff merged 1 commit into from
Apr 20, 2026
Merged

fix GSM-29: prevent duplicate theme deploys for the same PR #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions .github/workflows/shopify-theme-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,27 @@ jobs:
- name: Install Shopify CLI
run: npm install -g @shopify/cli@latest

- name: Push unpublished theme
- name: Push theme
working-directory: ${{ inputs.working-directory }}
run: |
shopify theme push \
--unpublished \
--json \
--theme "$PR_THEME_NAME" \
> push.json
# Check if a theme with this name already exists
EXISTING_ID=$(shopify theme list --json \
| jq -r --arg name "$PR_THEME_NAME" '.[] | select(.name == $name) | .id // empty')

if [ -n "$EXISTING_ID" ]; then
echo "Updating existing preview theme (ID: $EXISTING_ID)"
shopify theme push \
--json \
--theme "$EXISTING_ID" \
> push.json
else
echo "Creating new preview theme"
shopify theme push \
--unpublished \
--json \
--theme "$PR_THEME_NAME" \
> push.json
fi

- name: Extract preview URL
id: preview
Expand Down