Allow purl to eval in a non-browser environment#68
Open
lfac-pt wants to merge 1 commit intoallmarkedup:masterfrom
Open
Allow purl to eval in a non-browser environment#68lfac-pt wants to merge 1 commit intoallmarkedup:masterfrom
lfac-pt wants to merge 1 commit intoallmarkedup:masterfrom
Conversation
During the build process of a project I'm working on, purl gets evaled by https://github.com/jrburke/r.js, which is running on node, and as such there is no window object. This commit makes some very small changes to allow purl to eval and to work on a non-browser environment, namely it does not require `window` to exist.
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the build process of a project I'm working on, purl gets evaled by https://github.com/jrburke/r.js, which is running on node, and as such there is no window object.
This commit makes some very small changes to allow purl to eval and to work on a non-browser environment, namely it does not require
windowto exist.