Skip to content

Conversation

@rroohhh
Copy link
Contributor

@rroohhh rroohhh commented May 14, 2025

pypy does not have _varname_from_oparg, so fall back to pre cpython-3.11 path

ref: https://github.com/pypy/pypy/blob/0253c85bf5f86a45760eda7f0af8953ed8a253c7/lib-python/3/dis.py#L351

pypy does not have _varname_from_oparg, so fall back to pre cpython-3.11 path
ref: https://github.com/pypy/pypy/blob/0253c85bf5f86a45760eda7f0af8953ed8a253c7/lib-python/3/dis.py#L351
@rroohhh
Copy link
Contributor Author

rroohhh commented May 14, 2025

So now this hits pypy/pypy#3183 in sby, so blocked on YosysHQ/sby#323 I guess.

@whitequark
Copy link
Member

Let's add a @unittest.skipIf to those sby tests; it's not like missing them on a single PyPy version is going to impact anything.

@whitequark whitequark enabled auto-merge May 14, 2025 15:53
@whitequark
Copy link
Member

Thanks!

@whitequark whitequark added this pull request to the merge queue May 14, 2025
Merged via the queue into amaranth-lang:main with commit 9167910 May 14, 2025
19 of 20 checks passed
@rroohhh rroohhh deleted the pypy-3.11 branch May 14, 2025 16:09
@whitequark whitequark mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants