[Amber] Fix: Workflow startup greeting should render client-side, not round-trip through Claude#780
Open
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
…tripping through Claude When a user selects a workflow, the startupPrompt from ambient.json is now displayed directly in the WelcomeExperience component rather than being sent as a hidden user message to the Claude API. This eliminates an unnecessary round-trip that added latency and consumed API tokens. - Backend: expose `startupPrompt` from ambient.json in the OOTB workflow list API - Frontend: add `startupPrompt` to WorkflowConfig and OOTBWorkflow types - Frontend: track and expose `workflowGreeting` from useWorkflowManagement hook - Frontend: render greeting message in WelcomeExperience after workflow selection - Runner: remove `_trigger_workflow_greeting()` and its aiohttp/uuid dependencies Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
amber-generated
4 tasks
jeremyeder
pushed a commit
that referenced
this pull request
Mar 8, 2026
Tests that precisely validate the Critical fix from the PR #780 review: 1. Switching from a workflow WITH startupPrompt to one WITHOUT must clear workflowGreeting to null (not leave stale greeting displayed). 2. Empty-string startupPrompt must also clear the greeting. 3. Failed activation must not set any greeting. All 3 tests FAIL on the pre-patch code (conditional setWorkflowGreeting) and PASS on the fix (unconditional setWorkflowGreeting). Adds vitest + @testing-library/react as devDependencies and a minimal vitest.config.ts, matching the test infrastructure from PR #834. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeremyeder
added a commit
to jeremyeder/platform
that referenced
this pull request
Mar 9, 2026
…tup greeting with review fixes Combines the workflow startup greeting feature (PR ambient-code#780) with review feedback fixes (PR ambient-code#846) into a single PR. Includes pre-commit formatting fixes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremyeder
pushed a commit
to jeremyeder/platform
that referenced
this pull request
Mar 9, 2026
Tests that precisely validate the Critical fix from the PR ambient-code#780 review: 1. Switching from a workflow WITH startupPrompt to one WITHOUT must clear workflowGreeting to null (not leave stale greeting displayed). 2. Empty-string startupPrompt must also clear the greeting. 3. Failed activation must not set any greeting. All 3 tests FAIL on the pre-patch code (conditional setWorkflowGreeting) and PASS on the fix (unconditional setWorkflowGreeting). Adds vitest + @testing-library/react as devDependencies and a minimal vitest.config.ts, matching the test infrastructure from PR ambient-code#834. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jeremyeder
added a commit
to jeremyeder/platform
that referenced
this pull request
Mar 9, 2026
…tup greeting with review fixes Combines the workflow startup greeting feature (PR ambient-code#780) with review feedback fixes (PR ambient-code#846) into a single PR. Includes pre-commit formatting fixes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
jeremyeder
added a commit
to jeremyeder/platform
that referenced
this pull request
Mar 9, 2026
…ode#780 + ambient-code#846) Replaces the server-side workflow greeting round-trip with a client-side approach that provides instant feedback when users select a workflow. Backend: - Add `startupPrompt` and `greeting` fields to OOTBWorkflow struct - Parse both fields from ambient.json in workflow repos Frontend: - Display `greeting` text with typewriter streaming effect below tiles - Add `hidden` option to sendMessage for system-initiated messages - Remove 3-second hardcoded sleep after workflow activation - Remove server-side workflowGreeting state (no LLM round-trip needed) Runner: - Remove server-side greeting trigger logic (no longer needed) - Clean up unused imports (aiohttp, uuid, load_ambient_config) Tests: - Add vitest regression tests for stale greeting and race conditions - Add vitest.config.ts for frontend unit testing Companion: ambient-code/workflows#61 (ambient.json fixes) Supersedes ambient-code#780 and ambient-code#846. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Review Queue — Blockers Found
Action needed: Author needs to resolve merge conflicts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Fix by Amber Agent
This PR addresses issue #779 using the Amber background agent.
Changes Summary
Pre-merge Checklist
Reviewer Notes
This PR was automatically generated. Please review:
🤖 Generated with Amber Background Agent
Closes #779