-
Notifications
You must be signed in to change notification settings - Fork 7
sbtsi: Add support to reporting SBTSI maximum HBM temperature #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
akky16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for raising the PR, can you please help to address few review comments?
Add a new channel to support SBTSIx50 and SBTSIx54 for reporting maximum HBM temperature.
229e87a to
6617133
Compare
|
Add the Label, Max and Min: |
|
Akshay, TSI registers 0x50 and 0x54 do not report any value on EPYC processors, SB-TSI driver has no way to know the platform to conditionally support the hwmon entries. HBM temp information is available via APML, DIMM temp info is also available for EPYC processors, as SBRMI driver is aware of the platform via CPUID or simliar. can we expose hwmon entries for HBM/DIMM temp from SBRMI instead. |
|
SBRMI through mailbox provides way to get the max HBM temp (highest of all stacks) using mailbox command 0xA1, |
|
Hi @bges HBM is only applicable for MI and not for EPYC platforms. We can approve this PR for a branch, but upstreaming is difficult. |
Add a new channel to support SBTSIx50 and SBTSIx54 for reporting maximum HBM temperature.
Test result on MI300C platform
CPU temperature:
$ cat /sys/bus/i3c/drivers/sbtsi_i3c/0-22400000001/hwmon/hwmon16/temp1_input
41750
Max HBM Temperature:
$ cat /sys/bus/i3c/drivers/sbtsi_i3c/0-22400000001/hwmon/hwmon16/temp2_input
32000