-
Notifications
You must be signed in to change notification settings - Fork 19
add custom cassandra repository with ttl #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brenoreis
wants to merge
3
commits into
develop
Choose a base branch
from
feature/synapse-data-cassandra/add-custom-repository
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...ndra-book/src/main/java/io/americanexpress/data/book/repository/CustomBookRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright 2020 American Express Travel Related Services Company, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package io.americanexpress.data.book.repository; | ||
|
|
||
| import io.americanexpress.data.book.entity.BookEntity; | ||
| import io.americanexpress.synapse.data.cassandra.repository.CustomCassandraRepository; | ||
| import org.springframework.beans.factory.annotation.Qualifier; | ||
| import org.springframework.data.cassandra.core.CassandraTemplate; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| /** | ||
| * {@code CustomBookRepository} is the custom repository to handle the queries for the books table. | ||
| * | ||
| * @author brenoreis | ||
| */ | ||
| @Repository | ||
| public class CustomBookRepository extends CustomCassandraRepository<BookEntity> { | ||
|
|
||
| /** | ||
| * Creates a new instance of {@code CustomCassandraRepository} given a Cassandra template and time to live. | ||
| * | ||
| * @param cassandraTemplate the Cassandra template. | ||
| * @param timeToLive the time to live. | ||
| */ | ||
| protected CustomBookRepository(CassandraTemplate cassandraTemplate, @Qualifier("bookTimeToLive") int timeToLive) { | ||
| super(cassandraTemplate, timeToLive); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
...ra-book/src/test/java/io/americanexpress/data/book/repository/CustomBookRepositoryIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /* | ||
| * Copyright 2020 American Express Travel Related Services Company, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except | ||
| * in compliance with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License | ||
| * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package io.americanexpress.data.book.repository; | ||
|
|
||
| import io.americanexpress.data.book.config.BookDataTestConfig; | ||
| import io.americanexpress.data.book.entity.BookEntity; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.autoconfigure.AutoConfigurationPackage; | ||
| import org.springframework.boot.test.autoconfigure.data.cassandra.DataCassandraTest; | ||
| import org.springframework.test.context.ContextConfiguration; | ||
| import java.util.Optional; | ||
|
|
||
| /** | ||
| * {@code CustomBookRepositoryIT} class runs integration test on local Cassandra instance test database. | ||
| */ | ||
| @DataCassandraTest | ||
| @ContextConfiguration(classes = BookDataTestConfig.class) | ||
| @AutoConfigurationPackage | ||
| class CustomBookRepositoryIT { | ||
|
|
||
| private final CustomBookRepository customBookRepository; | ||
|
|
||
| private final BookRepository bookRepository; | ||
|
|
||
| @Autowired | ||
| public CustomBookRepositoryIT(CustomBookRepository customBookRepository, BookRepository bookRepository) { | ||
| this.customBookRepository = customBookRepository; | ||
| this.bookRepository = bookRepository; | ||
| } | ||
|
|
||
| @BeforeEach | ||
| void clean() { | ||
| bookRepository.deleteAll(); | ||
| } | ||
|
|
||
| @Test | ||
| void findAll_givenEmptyBookCollection_expectedNoBooksFound() { | ||
| Assertions.assertEquals(0, bookRepository.findAll().size()); | ||
| } | ||
|
|
||
| @Test | ||
| void findByTitleAndAuthor_givenBook_expectedBookFound() throws InterruptedException { | ||
| BookEntity bookEntity = new BookEntity("Alice In Wonderland", "Lewis Carroll"); | ||
| customBookRepository.save(bookEntity); | ||
|
|
||
| Optional<BookEntity> book = bookRepository.findByTitleAndAuthor("Alice In Wonderland", "Lewis Carroll"); | ||
| Assertions.assertEquals(bookEntity.getTitle(), book.get().getTitle()); | ||
|
|
||
| Thread.sleep(5000); | ||
|
|
||
| book = bookRepository.findByTitleAndAuthor("Alice In Wonderland", "Lewis Carroll"); | ||
| Assertions.assertFalse(book.isPresent()); | ||
| } | ||
| } |
51 changes: 51 additions & 0 deletions
51
.../java/io/americanexpress/synapse/data/cassandra/repository/CustomCassandraRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package io.americanexpress.synapse.data.cassandra.repository; | ||
|
|
||
| import org.springframework.data.cassandra.core.CassandraTemplate; | ||
| import org.springframework.data.cassandra.core.InsertOptions; | ||
| import java.time.Duration; | ||
|
|
||
| /** | ||
| * {@code CustomCassandraRepository} is the custom repository for Cassandra. | ||
| * This Repository is used to add ttl to your entities records. | ||
| * The ttl is taken from the bean created in the config which get the ttl value from the property file. | ||
| * | ||
| * @author breisalm | ||
| */ | ||
| public abstract class CustomCassandraRepository<T> { | ||
|
|
||
| /** | ||
| * The Cassandra template. | ||
| */ | ||
| private final CassandraTemplate cassandraTemplate; | ||
|
|
||
| /** | ||
| * The time to live. | ||
| */ | ||
| private final int timeToLive; | ||
|
|
||
| /** | ||
| * Creates a new instance of {@code CustomCassandraRepository} given a Cassandra template and time to live. | ||
| * | ||
| * @param cassandraTemplate the Cassandra template. | ||
| * @param timeToLive the time to live. | ||
| */ | ||
| protected CustomCassandraRepository(CassandraTemplate cassandraTemplate, | ||
| int timeToLive) { | ||
| this.cassandraTemplate = cassandraTemplate; | ||
| this.timeToLive = timeToLive; | ||
| } | ||
|
|
||
| /** | ||
| * Saves the entity. | ||
| * | ||
| * @param entity the entity. | ||
| * @return the saved entity. | ||
| */ | ||
| public T save(T entity) { | ||
| return cassandraTemplate.insert(entity, | ||
| InsertOptions.builder() | ||
| .ttl(Duration.ofSeconds(timeToLive)) | ||
| .build()) | ||
| .getEntity(); | ||
| } | ||
brenoreis marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.