feat: add support for setting user agent on event#61
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for a new user_agent field on Event objects, enabling clients to set a custom user-agent string when sending events.
- Extend
EventOptionsproperty mapping to includeuser_agent - Add
user_agentparameter toEventOptionsand allBaseEventsubclasses - Update docstrings to describe the new parameter
Comments suppressed due to low confidence (2)
src/amplitude/event.py:167
- No unit tests were added to verify that the user_agent property is correctly included in the event payload. Consider adding tests for this behavior.
"user_agent": ["user_agent", str]
src/amplitude/event.py:213
- Public documentation (e.g., README, reference guide) should be updated to document the new user_agent parameter and its usage examples.
user_agent (str, optional): The user agent string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for user_agent property
Checklist