refactor: move evaluation classes into AmplitudeAnalytics module#76
Closed
FabricioFFC wants to merge 4 commits intoamplitude:mainfrom
Closed
refactor: move evaluation classes into AmplitudeAnalytics module#76FabricioFFC wants to merge 4 commits intoamplitude:mainfrom
FabricioFFC wants to merge 4 commits intoamplitude:mainfrom
Conversation
a4a4fc7 to
0c2173f
Compare
Collaborator
|
@FabricioFFC thank you so much for bringing this up! I've used your branch to start and made some slight adjustments on your take here: #77 I hope you don't mind - I felt this would be faster than the back-and-forth. |
Author
@kyeh-amp no problem. Are you planning to include the other small changes that aren't related to the |
Collaborator
|
This change was included in today's release of v1.7.1. Closing this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're migrating to the Amplitude SDK, and during this process, we noticed that some module names (e.g., Evaluation) conflict with the third party feature-flag SDK we currently use.
This PR resolves the conflict by adding all classes and modules that were not already namespaced to the
AmplitudeExperimentmodule.Besides that there are some minor changes included:
For reviewers: enabling
Hide whitespacewill reduce noise in the diff and make the PR easier to review. :)Checklist