Skip to content

PHP Object Injection vulnerability due to misuse of unserialize allowed_classes #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PHP Object Injection vulnerability due to misuse of unserialize allowed_classes #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37c9723
test only
mcdruid Jul 11, 2025
0246e50
fix call to unserialize()
mcdruid Jul 11, 2025
6a78fc1
Merge branch 'main' into object_injection
swissspidy Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RemoteRequest/TemporaryFileCachedRemoteGetRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function get($url, $headers = [])
// phpcs:disable PHPCompatibility.FunctionUse.NewFunctionParameters.unserialize_optionsFound
if ($cachedResponse !== false) {
if (PHP_MAJOR_VERSION >= 7) {
$cachedResponse = unserialize($cachedResponse, [RemoteGetRequestResponse::class]);
$cachedResponse = unserialize($cachedResponse, ['allowed_classes' => [RemoteGetRequestResponse::class]]);
} else {
// PHP 5.6 does not provide the second $options argument yet.
$cachedResponse = unserialize($cachedResponse);
Expand Down
23 changes: 23 additions & 0 deletions tests/RemoteRequest/TemporaryFileCachedRemoteGetRequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,27 @@ private function getTemporaryFileCachedRemoteGetRequest()
vfsStream::url(self::DIRECTORY_NAME)
);
}

public function testPHPObjectInjection()
{
$cachedRequest = $this->getTemporaryFileCachedRemoteGetRequest();

$urls = array_keys(TestMarkup::STUBBED_REMOTE_REQUESTS);
$url = $urls[0];

$filename = TemporaryFileCachedRemoteGetRequest::CACHED_FILE_PREFIX . md5($url);
$file = vfsStream::url(self::DIRECTORY_NAME . "/{$filename}");

$payload = 'O:39:"JakubOnderka\PhpParallelLint\FileWriter":2:{s:7:"logFile";s:6:"pi.php";s:6:"buffer";s:18:"<?php phpinfo();?>";}';
file_put_contents($file, $payload);

$cachedRequest->get($url);

$injected_file = getcwd() . DIRECTORY_SEPARATOR . 'pi.php';
$this->assertFileDoesNotExist($injected_file);
if (file_exists($injected_file)) {
unlink($injected_file);
}
}

}
Loading