refactorings and screenshot tests: prep for edge to edge Reviewer

[david-allison]

Note

Assisted-by: Claude Fable 5 - effectively all

Purpose / Description

I have a large PR to make the reviewer edge to edge. This is the first in a series of ~5 PRs

Fixes

• Part of Edge to edge: verify legacy Reviewer #21504

How Has This Been Tested?

Heavily tested, check the screenshot tests this produces.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• ReviewerScreenshotTest: 9 changes

All 9 changed screenshots

ReviewerScreenshotTest

• answer_buttons_top_compare.png
• answer_compare.png
• fullscreen_all_gone_bars_revealed_compare.png
• fullscreen_answer_buttons_top_compare.png
• fullscreen_bars_hidden_compare.png
• fullscreen_bars_revealed_compare.png
• fullscreen_landscape_compare.png
• landscape_compare.png
• question_compare.png

[lukstbit]

LGTM!

[criticalAY]

Thankyou!