Skip to content

fix(review-reminders): truncated troubleshooting checks in landscape - #21580

Merged
ericli3690 merged 1 commit into
ankidroid:mainfrom
david-allison:21575
Aug 28, 2026
Merged

fix(review-reminders): truncated troubleshooting checks in landscape#21580
ericli3690 merged 1 commit into
ankidroid:mainfrom
david-allison:21575

Conversation

@david-allison

@david-allison david-allison commented Aug 23, 2026

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Fixes

Approach

NestedScrollView

How Has This Been Tested?

Pixel 9 Pro; API 37

image

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@github-actions

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • ReviewRemindersScreenshotTest: 1 change
All 1 changed screenshots

ReviewRemindersScreenshotTest

  • standaloneActivityHost_troubleshooting_systemBars_compare.png

@david-allison

david-allison commented Aug 26, 2026

Copy link
Copy Markdown
Member Author
standaloneActivityHost_troubleshooting_systemBars_compare

This is correct:

binding.scrollView.scrollTo(0, binding.scrollView.getChildAt(0).bottom)

@david-allison david-allison added the Review High Priority Request for high priority review label Aug 26, 2026

@lukstbit lukstbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Aug 27, 2026

@ericli3690 ericli3690 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@ericli3690 ericli3690 added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Aug 28, 2026
@ericli3690
ericli3690 added this pull request to the merge queue Aug 28, 2026
Merged via the queue into ankidroid:main with commit 3cd08db Aug 28, 2026
24 of 25 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Aug 28, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev-only] Review reminders troubleshooting: truncated in landscape mode

3 participants