Skip to content

feat(reviewer): call enableEdgeToEdge (partial support) - #21581

Open
david-allison wants to merge 1 commit into
ankidroid:mainfrom
david-allison:21504-reviewer-edge-to-edge-2
Open

feat(reviewer): call enableEdgeToEdge (partial support)#21581
david-allison wants to merge 1 commit into
ankidroid:mainfrom
david-allison:21504-reviewer-edge-to-edge-2

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Fable 5

Purpose / Description

This kicks off edge to edge support in the Reviewer via calling enableEdgeToEdge(), the insets for the various components are then set.

This does not impact fullscreenMode yet.

(note: this will be a very complex change, multiple PRs will be added, so this change alone does not provide perfect support)

highlights:

  • The nav bar is now transparent, taking the color above it
    • Fixes the 3-button nav on some devices
  • in landscape, the app bar and counts bar now render in the camera notch

A bottom inset (based on answer position) is added:

  • bottom (default): the answer area clears the navigation bar and, since edge-to-edge disables adjustResize, the keyboard (ime())
  • top: the card is the bottom-most element and takes the inset
  • none: the bottom area (type-answer field) takes the inset

Fixes

Approach

  • call enableEdgeToEdge
  • Define the insets for each view which would have been affected, moving it back to its correct position

How Has This Been Tested?

Pixel 9 Pro - API 37

1
image
image

2
image
image

3
image
image

4
image
image

5
image
image

6
image
image

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

This kicks off edge to edge support in the Reviewer via
calling `enableEdgeToEdge()`, the insets for the various
components are then set.

This does not impact fullscreenMode yet.

(note: this will be a very complex change, multiple PRs will be
added, so this change alone does not provide perfect support)

highlights:

* The nav bar is now transparent, taking the color above it
  * Fixes the 3-button nav on some devices
* in landscape, the app bar and counts bar now render in the camera notch

A bottom inset (based on answer position) is added:

* bottom (default): the answer area clears the navigation bar and,
  since edge-to-edge disables adjustResize, the keyboard (ime())
* top: the card is the bottom-most element and takes the inset
* none: the bottom area (type-answer field) takes the inset

Issue 17334, part of 21504 - edge to edge

Assisted-by: Claude Fable 5
@github-actions

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • ReviewerScreenshotTest: 3 changes
All 3 changed screenshots

ReviewerScreenshotTest

  • answer_compare.png
  • landscape_compare.png
  • question_compare.png

@david-allison david-allison added the Review High Priority Request for high priority review label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Review High Priority Request for high priority review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant