feat(reviewer): call enableEdgeToEdge (partial support) - #21581
Open
david-allison wants to merge 1 commit into
Open
feat(reviewer): call enableEdgeToEdge (partial support)#21581david-allison wants to merge 1 commit into
enableEdgeToEdge (partial support)#21581david-allison wants to merge 1 commit into
Conversation
This kicks off edge to edge support in the Reviewer via calling `enableEdgeToEdge()`, the insets for the various components are then set. This does not impact fullscreenMode yet. (note: this will be a very complex change, multiple PRs will be added, so this change alone does not provide perfect support) highlights: * The nav bar is now transparent, taking the color above it * Fixes the 3-button nav on some devices * in landscape, the app bar and counts bar now render in the camera notch A bottom inset (based on answer position) is added: * bottom (default): the answer area clears the navigation bar and, since edge-to-edge disables adjustResize, the keyboard (ime()) * top: the card is the bottom-most element and takes the inset * none: the bottom area (type-answer field) takes the inset Issue 17334, part of 21504 - edge to edge Assisted-by: Claude Fable 5
Contributor
|
Snapshot diff report vs
All 3 changed screenshotsReviewerScreenshotTest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Fable 5
Purpose / Description
This kicks off edge to edge support in the Reviewer via calling
enableEdgeToEdge(), the insets for the various components are then set.This does not impact fullscreenMode yet.
(note: this will be a very complex change, multiple PRs will be added, so this change alone does not provide perfect support)
highlights:
A bottom inset (based on answer position) is added:
Fixes
Reviewer#21504Approach
enableEdgeToEdgeHow Has This Been Tested?
Pixel 9 Pro - API 37
1


2


3


4


5


6


Checklist