feat(review-reminders): edge to edge support - #21582
Draft
david-allison wants to merge 11 commits into
Draft
Conversation
The study options containers are padded with the system bar insets, consuming them means they will not be applied twice. Non-functional prep for removing FragmentHost.supportsEdgeToEdge. Part of 17334 Part of 21519 Assisted-by: Claude Fable 5
Helper for Insets which provides the initial insets to the lambda Issue 17334 Assisted-by: Claude Fable 5
Issue 17334 Assisted-by: Claude Fable 5
Contributor
|
Snapshot diff report vs
All 11 changed screenshotsReviewRemindersScreenshotTest
|
david-allison
added
the
Needs Author Reply
Member
Author
|
macOS failure looks legit |
david-allison
force-pushed
the
edge-to-edge-schedule-reminders-cleanup
branch
from
August 24, 2026 00:08
9d974cf to
e0780d1
Compare
Issue 17334, 21519 Assisted-by: Claude Fable 5
Issue 17334, 21519 - edge to edge Assisted-by: Claude Fable 5
Baseline captures across the FragmentHosts, with simulated system bars: the edge-to-edge fixes then show up as image diffs. Adds an id to the troubleshooting scroll view so the test can scroll it. Issue 17334, 21519 Assisted-by: Claude Fable 5
The fragments now unconditionally fit the system windows: the host activities consume the insets. Issue 17334 Part of 21519 Assisted-by: Claude Fable 5
Part of 17334 Part of 21519 Assisted-by: Claude Fable 5
* Removes the black bar in landscape mode * Troubleshooting content renders underneath the bottom bar Part of 17334 Part of 21519 Assisted-by: Claude Fable 5
The content of the toolbar in landscape mode of a phone overlapped with the display cutout. Part of 17334 Assisted-by: Claude Fable 5
The decor consumed the navigation bar inset, so scrolled content did not render underneath the nav bar. Part of 17334 Fixes 21519 Assisted-by: Claude Fable 5
david-allison
force-pushed
the
edge-to-edge-schedule-reminders-cleanup
branch
from
August 24, 2026 00:34
e0780d1 to
b42c9cf
Compare
david-allison
added
Blocked by dependency
5 tasks
david-allison
marked this pull request as draft
August 24, 2026 00:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by dependencyCurrently blocked by some other dependent / related change
This has been split into:
Note
Assisted-by: Claude Fable 5
Purpose / Description
ScheduleRemindersFragmentandReminderTroubleshootingFragmentneeded edge to edge supportFixes
ScheduleRemindersFragment#21519Approach
Before starting, consume the insets which will be passed to the fragments, then set the insets on a per-element basis.
There was lots of experimentation here to get the screenshots working correctly (ensuring the toolbars extended into the cutouts, ensuring scrolling), each is split into a separate commit.
I have a follow-up implemented for 'Settings', but this PR is already too large:
How Has This Been Tested?
Screenshot tests are added.
API 37
Learning
FragmentHostmade this difficultChecklist