fix(info): do not raise the buttons above the navigation bar - #21586
Merged
Conversation
Contributor
|
Snapshot diff report vs
All 1 changed screenshotsInfoScreenshotTest
|
david-allison
approved these changes
Aug 24, 2026
david-allison
left a comment
Member
There was a problem hiding this comment.
LGTM
I had Fable give it a shot, and it defined a new bottomCornerClearance method which took a margin parameter.
I prefer this approach - less generic, but much simpler to understand.
lukstbit
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
We don't need bottom button clearance here sorry about that so updating the code and test
Fixes
Approach
ref commit
How Has This Been Tested?
Learning (optional, can help others)
Mistakes happen :)
Checklist
Please, go through these checks before submitting the PR.